fix(user): remove email from accounts
All checks were successful
CI/CD Pipeline / Code Quality Checks (pull_request) Successful in 2m11s
CI/CD Pipeline / Run Tests (pull_request) Successful in 4m32s
CI/CD Pipeline / Build and Push Dev Images (pull_request) Has been skipped
CI/CD Pipeline / Deploy Dev via Compose (pull_request) Has been skipped
CI/CD Pipeline / Code Quality Checks (push) Successful in 1m20s
CI/CD Pipeline / Run Tests (push) Successful in 3m21s
CI/CD Pipeline / Build and Push Dev Images (push) Has been skipped
CI/CD Pipeline / Deploy Dev via Compose (push) Has been skipped

This commit was merged in pull request #33.
This commit is contained in:
Aleksandr Meshchryakov
2026-10-01 10:20:01 +02:00
parent f3b731935e
commit e61f92200d
24 changed files with 239 additions and 295 deletions

View File

@@ -32,7 +32,6 @@ class UserRegistrationSerializerTest(TestCase):
def setUp(self):
self.password = fake.password(length=12, special_chars=False)
self.user_data = {
"email": fake.unique.email(),
"username": fake.unique.user_name(),
"password": self.password,
"password_confirm": self.password,
@@ -44,29 +43,24 @@ class UserRegistrationSerializerTest(TestCase):
serializer = UserRegistrationSerializer(data=self.user_data)
self.assertTrue(serializer.is_valid())
def test_local_registration_still_requires_email(self):
for value in (None, "", "missing"):
data = self.user_data.copy()
if value == "missing":
data.pop("email")
else:
data["email"] = value
serializer = UserRegistrationSerializer(data=data)
self.assertFalse(serializer.is_valid())
self.assertIn("email", serializer.errors)
def test_local_registration_without_email(self):
serializer = UserRegistrationSerializer(data=self.user_data)
self.assertTrue(serializer.is_valid(), serializer.errors)
self.assertNotIn("email", serializer.fields)
def test_admin_creation_still_requires_email(self):
def test_admin_creation_without_email(self):
from apps.user.serializers import AdminUserCreateSerializer
data = {
"username": "local",
"password": self.password,
"first_name": "Test",
"last_name": "User",
}
serializer = AdminUserCreateSerializer(data=data)
self.assertFalse(serializer.is_valid())
self.assertIn("email", serializer.errors)
serializer = AdminUserCreateSerializer(
data={
"username": "local",
"password": self.password,
"first_name": "Test",
"last_name": "User",
}
)
self.assertTrue(serializer.is_valid(), serializer.errors)
self.assertNotIn("email", serializer.fields)
def test_passwords_do_not_match(self):
"""Test validation fails when passwords don't match"""
@@ -90,17 +84,6 @@ class UserRegistrationSerializerTest(TestCase):
self.assertFalse(serializer.is_valid())
self.assertIn("password", serializer.errors)
def test_duplicate_email(self):
"""Test validation fails with duplicate email"""
existing_user = UserFactory.create_user()
data = self.user_data.copy()
data["email"] = existing_user.email
serializer = UserRegistrationSerializer(data=data)
self.assertFalse(serializer.is_valid())
self.assertIn("email", serializer.errors)
def test_duplicate_username(self):
"""Test validation fails with duplicate username"""
existing_user = UserFactory.create_user()
@@ -120,7 +103,6 @@ class UserRegistrationSerializerTest(TestCase):
user = serializer.save()
self.assertIsInstance(user, User)
self.assertEqual(user.email, self.user_data["email"])
self.assertEqual(user.username, self.user_data["username"])
self.assertTrue(user.check_password(self.user_data["password"]))
@@ -138,7 +120,6 @@ class UserSerializerTest(TestCase):
data = serializer.data
self.assertEqual(data["id"], self.user.id)
self.assertEqual(data["email"], self.user.email)
self.assertEqual(data["username"], self.user.username)
self.assertEqual(data["phone"], self.user.phone)
self.assertEqual(data["is_verified"], self.user.is_verified)